Enable more warning flags, and fix more warnings #3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Constructing a Chat with isServer=false would do the wrong thing. In C++, tag types are typically used for disambiguation of constructors. Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
tokenize() no longer relies on n_past. Signed-off-by: Jared Van Bortel <jared@nomic.ai>
cebtenzzre
force-pushed
the
jared/enable-more-warnings
branch
from
f0a03aa
to
8173ae0
Compare
manyoso
approved these changes
Oct 18, 2024
This removes the BM25 change, which conflicts with a proper fix made on main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3039.
-Wunused-variableis now enabled. The three warnings seemed benign and were fixed.-Wunused-parameter.bool isServer-isServer=falseandisServer=trueactually both created a server chat. This parameter was replaced with a tag struct to prevent confusion.-Wunused-functionis now enabled.One curiously unused function was goHighlightingRules() - we were calling javaHighlightingRules() for Go instead. This has been fixed.Moved to chatviewtextprocessor: fix Go syntax highlighting #3080.-Wswitchwarning was fixed in Kompute.std::is_podwere fixed in usearch. This warning is doing its job—this is very suspicious code; it really shouldn't be skipping construction/destruction for "plain old data" but not for other types. But we're a downstream project, so we can replace this with its functional equivalent oftrivial && standard_layoutand move on.