Fix compatibility with Qt 6.8 #3121
Merged
+40
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qt 6.8 made breaking changes to the QHttpServer API. It does have technology preview status, after all. Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
|
The CI build passed on the previous commit. The merge just updates the codespellrc so that check passes. The local server works fine on Qt 6.7 on macOS and on Qt 6.8 on Arch Linux with this change. |
Closed
manyoso
reviewed
Oct 21, 2024
manyoso
approved these changes
Oct 21, 2024
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt 6.8 made a few significant changes:
This PR allows GPT4All to build and run on Qt 6.8, while maintaining compatibility with older Qt versions.