Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Manifest + resolve environment at server start #21

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Update Manifest + resolve environment at server start #21

merged 1 commit into from
Apr 15, 2021

Conversation

ffevotte
Copy link
Collaborator

Following the discussion in #20, this PR

  • updates the shipped Manifest.toml for Julia 1.6
  • makes sure the environment gets resolved at each server start. This is needed because a Manifest produced by Julia 1.6 is not necessarily compatible with older Julia versions.

I've checked that working environments are resolved for Julia 1.4 and 1.5.

@ffevotte
Update Manifest + resolve environment at server start
6a09c48 
The new Manifest.toml is tailored for Julia 1.6.0.

Eglot-jl should still work with older Julia versions, since the environment is
re-resolved at each server start to make sure it is compatible with the current
Julia version.

Fixes: non-Jedi#20
@ffevotte ffevotte requested a review from non-Jedi April 14, 2021 22:41
@ffevotte ffevotte merged commit 657693f into non-Jedi:master Apr 15, 2021
@ffevotte ffevotte deleted the update-1.6 branch April 15, 2021 10:49
@ffevotte ffevotte mentioned this pull request Jan 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@non-Jedi non-Jedi non-Jedi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ffevotte @non-Jedi