Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: 允许继承 Message 和 MessageSegment #66

Merged
merged 5 commits into from
Jun 4, 2023

Conversation

A-kirami
Copy link
Contributor

@A-kirami A-kirami commented Jun 3, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Merging #66 (b85d9ee) into master (d72bdeb) will increase coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   67.77%   67.78%   +0.01%     
==========================================
  Files          23       23              
  Lines        2079     2080       +1     
==========================================
+ Hits         1409     1410       +1     
  Misses        670      670              
Flag Coverage Δ
unittests 67.78% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nonebot/adapters/onebot/v11/message.py 81.81% <66.66%> (+0.11%) ⬆️

@github-actions
Copy link

github-actions bot commented Jun 3, 2023

@github-actions github-actions bot temporarily deployed to pull request June 3, 2023 19:16 Inactive
Copy link
Member

@yanyongyu yanyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请在pyproject里添加typing extensions并更新lock

@github-actions github-actions bot temporarily deployed to pull request June 4, 2023 06:58 Inactive
Copy link
Member

@yanyongyu yanyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

要不顺便把staticmethod都改成classmethod吧

@A-kirami A-kirami changed the title Feat: 允许继承 Message Feat: 允许继承 Message 和 MessageSegment Jun 4, 2023
@A-kirami A-kirami requested a review from yanyongyu June 4, 2023 08:20
@github-actions github-actions bot temporarily deployed to pull request June 4, 2023 08:20 Inactive
@yanyongyu yanyongyu changed the title Feat: 允许继承 Message 和 MessageSegment Feature: 允许继承 Message 和 MessageSegment Jun 4, 2023
@yanyongyu yanyongyu added the enhancement New feature or request label Jun 4, 2023
@yanyongyu yanyongyu merged commit 349d0b0 into nonebot:master Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants