Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC | Health CLI refactoring ideas #8318

Open
9 tasks
romayalon opened this issue Aug 29, 2024 · 1 comment
Open
9 tasks

NC | Health CLI refactoring ideas #8318

romayalon opened this issue Aug 29, 2024 · 1 comment
Labels
Non Containerized Non containerized

Comments

@romayalon
Copy link
Contributor

romayalon commented Aug 29, 2024

Environment info

  • NooBaa Version: master
  • Platform: NC

Refactoring Suggestion

  • 1. Add validation of the config directory.
  • 2. Change the response to have more informative names, specifically total_fork_count and running_workers caused some confusion in the past.
  • 3. Remove error_type when not needed.
  • 4. Check the accessibility of a bucket path by the owner of the bucket - see Acess Denied for S3 buckets is not reporting #8240
  • 5. Add a flag for not checking permissions.
  • 6. Add an account/bucket schema validation (currently it's just a json schema check).
  • 7. rename MISSING_CONFIG error, this name does not fit because we iterate the config directory.
  • 8. add jsdocs.
  • 9. merge is_dir_accessible() and stat() to a single function that handles both.
@romayalon
Copy link
Contributor Author

romayalon commented Dec 8, 2024

Some more refactoring ideas based on code review of #8532

  1. fork_response_code.NOT_RUNNING is confusing - NC | Online Upgrade | Health CLI update config directory and upgrade checks #8532 (comment)
  2. convert multiple used strings to constants - NC | Online Upgrade | Health CLI update config directory and upgrade checks #8532 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Non Containerized Non containerized
Projects
None yet
Development

No branches or pull requests

2 participants