NC | Online Upgrade | Health CLI update config directory and upgrade checks #8532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romayalon
force-pushed
the
romy-online-upgrade-health
branch
from
89f3503 to
45af106
Compare
naveenpaul1
reviewed
Nov 18, 2024
shirady
reviewed
Dec 1, 2024
romayalon
force-pushed
the
romy-online-upgrade-health
branch
from
26c5f80 to
edd1766
Compare
shirady
approved these changes
Dec 8, 2024
src/manage_nsfs/health.js
Outdated
| const service_health = service_status !== 'active' || pid === '0' || response_code !== 'RUNNING' ? 'NOTOK' : 'OK'; | ||
|
|
||
| const error_code = await this.get_error_code(service_status, pid, response_code); | ||
| const endpoint_response_code = endpoint_state ? endpoint_state.response?.response_code : 'NOT_RUNNING'; |
There was a problem hiding this comment.
with this change endpoint_state.response?.response_code we might have endpoint_response_code undefined, do we know how to handle this?
There was a problem hiding this comment.
it was actually a fix for a bug I saw when running Health CLI while server is down,
I thought about your question and I think that the previous decision to make the default NOT_RUNNING is wrong and it should be UNKNOWN, so I changed it appropiatly.
This was referenced Dec 8, 2024
…checks Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
romayalon
force-pushed
the
romy-online-upgrade-health
branch
from
1742c11 to
eaf443f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Upgrade, it's showing in the logs of the endpoint, CLI etc.Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
sudo node ./node_modules/mocha/bin/mocha src/test/unit_tests/test_nc_health.js