Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use async-await in test_agent_blocks_reclaimer #7677

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Dec 21, 2023

Explain the changes

  1. Use async-await in test_agent_blocks_reclaimer(started in commit a81231b part of PR Minor Fixes in unit tests and Typo fixes #5835 ).
  2. Update occurrences of deprecated functions in promise.js.

Issues: Fixed #xxx / Gap #xxx

  1. none.

Testing Instructions:

make run-single-test testname=test_agent_blocks_reclaimer.js CONTAINER_PLATFORM=linux/arm64 (I'm using the flag CONTAINER_PLATFORM because I have MacOS M1). See:

5 passing (1m) return code was: 0

  • Doc added/updated
  • Tests added

@shirady shirady self-assigned this Dec 21, 2023
- Use async-await in test_agent_blocks_reclaimer.
- Update occurrences of deprecated functions in promise.js.

Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
@shirady shirady merged commit 1363ead into noobaa:master Dec 24, 2023
8 of 9 checks passed
@shirady shirady deleted the async-unit-test branch December 24, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants