Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | NC | CLI | add/update bucket policy of a bucket #7678

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Dec 21, 2023

Explain the changes

  1. Added --bucket policy flag to bucket add/update
  2. fix bucket policy to be tested by account.name and not account.email when using nsfs nc

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

@romayalon romayalon force-pushed the romy-manage-bucket-policy branch from 71cce16 to 9d4c784 Compare December 21, 2023 20:04
@romayalon romayalon requested a review from naveenpaul1 January 1, 2024 08:39
@romayalon romayalon force-pushed the romy-manage-bucket-policy branch 3 times, most recently from 9f9d1f1 to f9f14bd Compare January 2, 2024 15:48
Copy link
Contributor

@naveenpaul1 naveenpaul1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
small comment added

src/sdk/bucketspace_fs.js Outdated Show resolved Hide resolved
@romayalon romayalon force-pushed the romy-manage-bucket-policy branch from f9f14bd to ad28167 Compare January 3, 2024 10:36
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon romayalon force-pushed the romy-manage-bucket-policy branch from ad28167 to c4f6535 Compare January 3, 2024 10:48
@romayalon romayalon merged commit 723193b into noobaa:master Jan 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants