-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NSFS | NC | CLI | add filter to list #7681
Conversation
59d265a
to
2bcff87
Compare
@romayalon @guymguym This PR adds the filter but only allows the filter by UID and GID or a combination. If we add a filter to the name, it will, with a combination of the wide flag, be exact as status. In that case, I think we should also have the status, as it is more straight forward, but it is also redundant, so we can go with removing it if we choose. |
2bcff87
to
79b008d
Compare
3bd2422
to
bad0bdb
Compare
@liranmauda please remove the automatic closure of the github issues and add a request validation label and a comment tagging the person who opened the issue. thanks! |
bad0bdb
to
ed2f010
Compare
NSFS | NC | CLI | add filter to list Signed-off-by: liranmauda <liran.mauda@gmail.com>
ed2f010
to
8007ca2
Compare
Explain the changes
add a filter to lis: using the flags
--uid
or/and--gid
we can filter the account listIf we would like to add more fields then we can add them to the
_.pick
Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
sudo npx jest test_nc_nsfs_account_cli.test.js
sudo node --allow-natives-syntax ./node_modules/.bin/_mocha src/test/unit_tests/test_nc_nsfs_cli.js