Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | NC | Allow one or more buckets to use the same dir path #7718

Merged
merged 1 commit into from
Jan 22, 2024
Merged

NSFS | NC | Allow one or more buckets to use the same dir path #7718

merged 1 commit into from
Jan 22, 2024

Conversation

naveenpaul1
Copy link
Contributor

Explain the changes

  1. Allow one or more buckets to use the same dir path for the storage
  2. Clean after bucket delete
  • delete temp dir from bucket dir,
    eg: config.NSFS_TEMP_DIR_NAME_<bucket._id> folder
  1. new property _id added to bucket and account
  2. config_file_exists() renamed to is_path_exists().
  3. Jest test added for bucket delete

Issues: Fixed #xxx / Gap #xxx

  1. NSFS | NC | Allow one or more buckets to use the same dir path for the storage #7717

Testing Instructions:

  1. Create two or more buckets with the same storage path and start a multipart upload
    verify the temp folder name
  • Doc added/updated
  • Tests added

@naveenpaul1 naveenpaul1 changed the title NSFS | NC | buckets with same dir NSFS | NC | Allow one or more buckets to use the same dir path Jan 12, 2024
Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few comments on the file test_nc_nsfs_schema_validation.test.js.

src/cmd/manage_nsfs.js Outdated Show resolved Hide resolved
src/util/native_fs_utils.js Outdated Show resolved Hide resolved
src/cmd/manage_nsfs.js Show resolved Hide resolved
src/util/native_fs_utils.js Outdated Show resolved Hide resolved
src/manage_nsfs/manage_nsfs_cli_errors.js Outdated Show resolved Hide resolved
src/sdk/bucketspace_fs.js Outdated Show resolved Hide resolved
src/server/system_services/schemas/nsfs_bucket_schema.js Outdated Show resolved Hide resolved
src/util/native_fs_utils.js Outdated Show resolved Hide resolved
src/util/native_fs_utils.js Outdated Show resolved Hide resolved
src/cmd/manage_nsfs.js Outdated Show resolved Hide resolved
src/sdk/bucketspace_fs.js Outdated Show resolved Hide resolved
src/sdk/bucketspace_fs.js Show resolved Hide resolved
src/cmd/manage_nsfs.js Outdated Show resolved Hide resolved
Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Released, please add the javadoc to the function for the typescript.

Signed-off-by: naveenpaul1 <napaul@redhat.com>
@naveenpaul1 naveenpaul1 merged commit a8ffbfb into noobaa:master Jan 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants