Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | NC | Verify IP Address When Passing IP List #7736

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Jan 18, 2024

Explain the changes

  1. Verify the IP address when passing the IP list.

Issues: Fixed #7729

  1. Currently we don't check that every address in the list is a valid IP address.

Testing Instructions:

  1. Manual test example: sudo node src/cmd/manage_nsfs whitelist --ips '["10.1.11"]'.
  2. For running the unit test with the new tests, please run:
    sudo node ./node_modules/.bin/_mocha src/test/unit_tests/test_nc_nsfs_cli.js
  • Doc added/updated
  • Tests added

Copy link
Contributor

@naveenpaul1 naveenpaul1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
@shirady shirady merged commit d7b172c into noobaa:master Jan 18, 2024
9 checks passed
@shirady shirady deleted the verify-ip-address branch January 18, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ip address format should be validated
2 participants