Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSFS | NC | Prevent Adding Additional Properties (Bucket Schema) #7830

Merged
merged 1 commit into from
Mar 6, 2024
Merged

NSFS | NC | Prevent Adding Additional Properties (Bucket Schema) #7830

merged 1 commit into from
Mar 6, 2024

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Feb 18, 2024

Explain the changes

  1. Prevent adding additional properties (bucket schema) - by using strictly on objects under schema that use ref (with an object underneath).

Issues: Fixed #7757

  1. Currently a user can add additional properties to the JSON of s3_policy, website, and encryption objects.

Testing Instructions:

  1. Using unit tests, please run: npx jest test_nc_nsfs_bucket_schema_validation.test.js.
  • Doc added/updated
  • Tests added (we had tests that were it.skip and in this PR we removed the skip part.

@shirady shirady self-assigned this Feb 18, 2024
@shirady
Copy link
Contributor Author

shirady commented Feb 18, 2024

@guymguym as I understand the strictify function is recursive - but it doesn't handle the ref.
The solution I suggest solves the issue, but I would like to discuss if you have a better idea.

@shirady shirady requested a review from liranmauda March 3, 2024 09:50
@shirady shirady force-pushed the nsfs-nc-prevent-additional-properties branch 2 times, most recently from 8db60ce to 9377127 Compare March 6, 2024 08:16
@shirady
NSFS | NC | Prevent adding additional properties (bucket schema)
0d17ba6 
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
@shirady shirady force-pushed the nsfs-nc-prevent-additional-properties branch from def84b7 to 0d17ba6 Compare March 6, 2024 15:30
@shirady shirady merged commit 8363cf7 into noobaa:master Mar 6, 2024
10 checks passed
@shirady shirady deleted the nsfs-nc-prevent-additional-properties branch March 6, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guymguym guymguym guymguym approved these changes

@dannyzaken dannyzaken Awaiting requested review from dannyzaken

@romayalon romayalon Awaiting requested review from romayalon

@naveenpaul1 naveenpaul1 Awaiting requested review from naveenpaul1

@liranmauda liranmauda Awaiting requested review from liranmauda

Assignees

@shirady shirady

Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NSFS | NC | Prevent Adding Additional Properties (Bucket Schema)
2 participants
@shirady @guymguym