Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NC | NSFS] Disallow incorrect storage classes #7847

Merged
merged 1 commit into from
Mar 5, 2024
Merged

[NC | NSFS] Disallow incorrect storage classes #7847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/sdk/namespace_fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3026,9 +3026,13 @@ class NamespaceFS {
async _is_storage_class_supported(storage_class) {
if (!storage_class || storage_class === s3_utils.STORAGE_CLASS_STANDARD) return true;

// TODO: Upon integration with underlying systems, we should
// check if archiving is actually supported or not
return config.NSFS_GLACIER_ENABLED || false;
if (storage_class === s3_utils.STORAGE_CLASS_GLACIER) {
// TODO: Upon integration with underlying systems, we should
// check if archiving is actually supported or not
return config.NSFS_GLACIER_ENABLED || false;
}

return false;
}

async append_to_migrate_wal(entry) {
Expand Down