NSFS | NC | Use --from_file
Option in Bucket Create
#7879
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
from_file
option in the bucket that would include validation. The JSON file will include options (as key-value structure) that are the same as the flags we suggest.bucket_policy
as an object in the JSON file.from_file
with an example of bucket creation in addition to account creation.test_nc_nsfs_account_cli.test.js
of typo (‘tha’ instead of ‘the’) and remove the ‘and check the details’ in case the tests should fail.test_nc_nsfs_bucket_cli.test.js
:from_file
option, and copy functions from the account test file.bucket_storage_path
, andbucket_temp_dir_path
but local in thedescribe
scope (else it creates issues since Jest running the tests in concurrency)Issues:
Currently, we had a gap in
from_file
when adding a new bucket.Testing Instructions:
Added unit tests, please run:
sudo npx jest test_nc_nsfs_bucket_cli.test.js