Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | NC | Use --from_file Option in Bucket Create #7879

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Mar 10, 2024

Explain the changes

  1. Add the from_file option in the bucket that would include validation. The JSON file will include options (as key-value structure) that are the same as the flags we suggest.
  2. Add a special case of bucket_policy as an object in the JSON file.
  3. Edit documentation of from_file with an example of bucket creation in addition to account creation.
  4. Edit comments in file test_nc_nsfs_account_cli.test.js of typo (‘tha’ instead of ‘the’) and remove the ‘and check the details’ in case the tests should fail.
  5. In Add bucket tests to file test_nc_nsfs_bucket_cli.test.js:
  • Add bucket tests using from_file option, and copy functions from the account test file.
  • Edit the tests not to have a global variable of bucket_storage_path, and bucket_temp_dir_path but local in the describe scope (else it creates issues since Jest running the tests in concurrency)

Issues:

Currently, we had a gap in from_file when adding a new bucket.

Testing Instructions:

Added unit tests, please run: sudo npx jest test_nc_nsfs_bucket_cli.test.js

  • Doc added/updated
  • Tests added

Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
@shirady shirady force-pushed the nsfs-nc-from-file-bucket branch from 3729825 to fc6060b Compare March 13, 2024 08:00
@shirady shirady merged commit c38086e into noobaa:master Mar 13, 2024
10 checks passed
@shirady shirady deleted the nsfs-nc-from-file-bucket branch March 13, 2024 09:04
@shirady shirady changed the title NSFS | NC | Use --from-file Option in Bucket Create NSFS | NC | Use --from_file Option in Bucket Create Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants