Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | NC | Manage NSFS | Remove wide Property from Fetch Data #7907

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Mar 18, 2024

Explain the changes

  1. Remove wide property from fetch_bucket_data fetch_account_data.
  2. Edit test with list wide to make sure there is a difference between list and list with wide flag.

Issues: Fixed #7871

  1. Currently, the wide property is fetched inside fetch_bucket_data and fetch_account_data while it is not a property of an account or bucket.

Testing Instructions:

Manual Tests:

  1. Create a couple of accounts and a couple of buckets (using Manage NSFS).
  2. List accounts using wide flag: sudo node src/cmd/manage_nsfs account list --wide
  3. List buckets using wide flag: sudo node src/cmd/manage_nsfs bucket list --wide

Unit Tests:

  • sudo npx jest test_nc_nsfs_account_cli.test.js (for example: 'cli list wide').

  • sudo node ./node_modules/.bin/_mocha src/test/unit_tests/test_nc_nsfs_cli.js (for example: 'cli bucket list - wide')

  • Doc added/updated

  • Tests added

@shirady shirady changed the title NSFS | NC | Manage NSFS | remove wide property from fetch data NSFS | NC | Manage NSFS | Remove wide Property from Fetch Data Mar 18, 2024
@shirady shirady self-assigned this Mar 18, 2024
…nd fetch_account_data

Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
@shirady shirady force-pushed the nsfs-nc-change-wide branch from d7c5416 to d65e6c0 Compare March 18, 2024 14:15
@shirady shirady requested a review from naveenpaul1 March 19, 2024 06:05
@shirady shirady merged commit 7a4182f into noobaa:master Mar 19, 2024
10 checks passed
@shirady shirady deleted the nsfs-nc-change-wide branch March 19, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NSFS | NC | wide Property Should Be Removed from fetch_bucket_data And fetch_account_data
2 participants