Bucket_logging: Change log object name format. #8128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranmauda
reviewed
Jun 13, 2024
Comment on lines
101
to
111
| if [[ "$log_field" =~ "log_bucket" ]]; then | ||
| IFS=: read -r -a log_values <<< "$log_field" | ||
| log_bucket_name=$(echo "${log_values[1]}" | tr -d '"' | sed 's/^[ \t]*//; s/[ \t]*$//') | ||
| continue | ||
| fi | ||
|
|
||
| if [[ "$log_field" =~ "log_prefix" ]]; then | ||
| IFS=: read -r -a prefix_values <<< "$log_field" | ||
| log_prefix_value=$(echo "${prefix_values[1]}" | tr -d '"' | sed 's/^[ \t]*//; s/[ \t]*$//') | ||
| if [[ "$log_field" =~ "source_bucket" ]]; then | ||
| IFS=: read -r -a source_values <<< "$log_field" | ||
| source_bucket_name=$(echo "${source_values[1]}" | tr -d '"' | sed 's/^[ \t]*//; s/[ \t]*$//') | ||
| continue | ||
| fi |
There was a problem hiding this comment.
Why do we need to duplicate it?
can't it be a function?
There was a problem hiding this comment.
It could be a function. I modified the code and can see that it is working. However, I find the current code more readable and less prone to errors. Moreover, we are not saving any lines of code; all it is doing is adding more complexity to understand the code.
liranmauda
approved these changes
Jun 17, 2024
At present we are creating log objects and giving them name based on log_prefix and log_bucket. There are some constraint to that and one is that a user can set same log bucket and log prefix for two different source buckets. That will cause logs from two different source buckets to go to same log objects. In addition to that, source bucket name in log file name will help to get it easily without processing log file. This source bucket name can be used to get more logging configuration, which can be helpful in further processing. Signed-off-by: Ashish Pandey <aspandey@redhat.com>
aspandey
force-pushed
the
change-log-object-name
branch
from
296899b to
f815a51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present we are creating log objects and giving them name based on log_prefix and log_bucket.
There are some constraint to that and one is that a user can set same log bucket and log prefix for two different source buckets. That will cause logs from two different source buckets to go to same log objects.
In addition to that, source bucket name in log file name will help to get it easily without processing log file.
This source bucket name can be used to get more logging configuration, which can be helpful in further processing.
Note: As we are not providing log_prefix in log object name, it should be retrieved and processed from system_store by bg service at the time of uploading objects on log bucket.