notifications | unit tests #8497
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alphaprinz
force-pushed
the
notifications_coretest
branch
10 times, most recently
from
596a084 to
5604bd0
Compare
alphaprinz
force-pushed
the
notifications_coretest
branch
from
5604bd0 to
56eb869
Compare
alphaprinz
force-pushed
the
notifications_coretest
branch
from
56eb869 to
329bf1d
Compare
alphaprinz
force-pushed
the
notifications_coretest
branch
7 times, most recently
from
64506ff to
0ef0a94
Compare
alphaprinz
force-pushed
the
notifications_coretest
branch
from
0ef0a94 to
231eb9c
Compare
Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
alphaprinz
force-pushed
the
notifications_coretest
branch
from
231eb9c to
e115cad
Compare
shirady
reviewed
Jan 5, 2025
| @@ -98,6 +98,7 @@ require('./test_tiering_ttl_worker'); | |||
| // require('./test_tiering_upload'); | |||
| //require('./test_s3_worm'); | |||
| require('./test_bucket_logging'); | |||
| require('./test_notifications'); | |||
There was a problem hiding this comment.
Do you want your tests to run only in a containerized environment?
We also have the nc_index for NC tests.
| config.NOTIFICATION_LOG_DIR = notif_logs_path; | ||
|
|
||
| coretest.setup({pools_to_create: [POOL_LIST[1]]}); | ||
| const { S3 } = require('@aws-sdk/client-s3'); |
There was a problem hiding this comment.
You can use generate_s3_client from test_utils.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: