Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC | Online Upgrade | RPM spec changes and github action for RPM install test #8516

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Nov 10, 2024

Explain the changes

  1. Instead of letting the RPM upgrade handle /usr/local/noobaa-core automatically, we first -
    a. copy the new source code to /usr/local/.noobaa-core-{new_version}/ hidden directory
    b. on the post section -
    i. move current version source code from /usr/local/noobaa-core/ to /usr/local/.noobaa-core-{current_version}/
    ii. move new version source code from /usr/local/.noobaa-core-{new_version}/ to /usr/local/noobaa-core/

This way we can ensure, untracked files added to the old noobaa-core source code dir are removed.

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  1. docker run --privileged --user root -d --platform=linux/amd64 oowy/redhat:ubi9
  2. docker exec -it {container_id} bash
  3. yum install wget
  4. install boost-system and boost-thread
    wget https://rpmfind.net/linux/centos-stream/9-stream/AppStream/x86_64/os/Packages/boost-system-1.75.0-8.el9.x86_64.rpm
    wget https://rpmfind.net/linux/centos-stream/9-stream/AppStream/x86_64/os/Packages/boost-thread-1.75.0-8.el9.x86_64.rpm
    rpm -i boost-system-1.75.0-8.el9.x86_64.rpm
    rpm -i boost-thread-1.75.0-8.el9.x86_64.rpm
  1. wget https://noobaa-core-rpms.s3.us-east-1.amazonaws.com/noobaa-core-5.16.0-20240403.el9.x86_64.rpm
  2. rpm -i noobaa-core-5.16.0-20240403.el9.x86_64.rpm
  3. mkdir /usr/local/noobaa-core/user-modified-dir/
  4. echo "blblblalal" > /usr/local/noobaa-core/user_modified_dir/user_modified_file
  5. wget https://noobaa-core-rpms.s3.us-east-1.amazonaws.com/${rpm having this PR changes}
  6. rpm -Uvh {rpm having this PR changes}
  7. check if /usr/local/noobaa-core still have user_modified_dir/user_modified_file
    and user_modified_dir/.
  • Doc added/updated
  • Tests added

@romayalon romayalon force-pushed the romy-online-upgrade-rpm branch from 16c6232 to a237086 Compare November 10, 2024 18:21
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 11, 2024
@romayalon romayalon closed this Nov 11, 2024
@romayalon romayalon reopened this Nov 11, 2024
@romayalon romayalon force-pushed the romy-online-upgrade-rpm branch 2 times, most recently from 14619b3 to 156d2e6 Compare November 11, 2024 15:07
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon romayalon force-pushed the romy-online-upgrade-rpm branch from 4d27cfd to e93b811 Compare December 18, 2024 13:26
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant