Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NC | Online Upgrade | Short refactoring #8615

Merged
merged 1 commit into from
Dec 23, 2024
Merged

NC | Online Upgrade | Short refactoring #8615

merged 1 commit into from
Dec 23, 2024

Conversation

romayalon
Copy link
Contributor

Explain the changes

  1. Created an enum called CONFIG_DIR_PHASES and moved it to config_fs and fixed the relevant dependencies.
  2. Declared a CONFIG_DIR_VERSION constant and changes this.config_dir_version to be CONFIG_DIR_VERSION.

Issues: Fixed #xxx / Gap #xxx

  1. Partially fixed NC | Online upgrade improvements #8586

Testing Instructions:

  • Doc added/updated
  • Tests added

@romayalon romayalon mentioned this pull request Dec 19, 2024
Open
12 tasks
@romayalon romayalon force-pushed the romy-config-dir-locked-unlocked-enum branch from 347e2a8 to 34a4ed0 Compare December 19, 2024 16:13
naveenpaul1
naveenpaul1 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@naveenpaul1 naveenpaul1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romayalon
NC | Online Upgrade | Short refactoring
ce3efbc 
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon romayalon force-pushed the romy-config-dir-locked-unlocked-enum branch from 34a4ed0 to ce3efbc Compare December 23, 2024 14:19
@romayalon romayalon merged commit 95e739f into noobaa:master Dec 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naveenpaul1 naveenpaul1 naveenpaul1 approved these changes

@shirady shirady Awaiting requested review from shirady

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NC | Online upgrade improvements
2 participants
@romayalon @naveenpaul1