Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | add option to unset supplemental groups using noobaa cli #8713

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

nadavMiz
Copy link
Contributor

@nadavMiz nadavMiz commented Jan 22, 2025

Explain the changes

  1. when setting supplemental groups as empty string (""), unset supplemental groups list for account. this is especially important following NSFS | set supplemental groups dynamically to users groups #8687 as when this value is undefined we will fetch the users groups from the os records
  2. continuation of NSFS | NC | add option to set account supplemental groups #8552

Issues: Fixed #8711

Testing Instructions:

automatic test:
run sudo npx jest test_nc_nsfs_account_cli.test.js
manual test:

  1. create new user with supplemental groups list defined:
    sudo node src/cmd/manage_nsfs.js account add --name test --uid 808 --gid 808 --supplemental_groups 101,22
  2. update account with "" supplemental_groups to unset this value:
    sudo node src/cmd/manage_nsfs.js account update --name test --supplemental_groups ""
  3. get status of the account. there should be no record for supplemental_groups:
    sudo node src/cmd/manage_nsfs.js account status --name test
  • Doc added/updated
  • Tests added

Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/manage_nsfs/manage_nsfs_help_utils.js Outdated Show resolved Hide resolved
src/manage_nsfs/manage_nsfs_cli_utils.js Outdated Show resolved Hide resolved
@nadavMiz nadavMiz force-pushed the unset_suplemental_groups branch from d199830 to 1881cae Compare January 22, 2025 14:44
Signed-off-by: nadav mizrahi <nadav.mizrahi16@gmail.com>
@nadavMiz nadavMiz force-pushed the unset_suplemental_groups branch from 1881cae to 77ee6e7 Compare January 22, 2025 15:35
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 22, 2025
@nadavMiz nadavMiz merged commit 97f8b75 into noobaa:master Jan 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NSFS | add option to unset supplemental groups using noobaa cli
3 participants