bucket notification - check pvcName, not pvc DFBUGS 988, 991 #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspandey
reviewed
Dec 6, 2024
alphaprinz
force-pushed
the
notif_fix
branch
2 times, most recently
from
4b96088 to
ba501f7
Compare
jackyalbo
approved these changes
Dec 10, 2024
Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
alphaprinz
force-pushed
the
notif_fix
branch
from
ba501f7 to
d084a69
Compare
alphaprinz
added a commit
to alphaprinz/noobaa-operator
that referenced
this pull request
Dec 10, 2024
…1485) Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
liranmauda
added a commit
that referenced
this pull request
Dec 11, 2024
bucket notification - check pvcName, not pvc DFBUGS 988, 991 (#1485)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
The check for whether there's already a pvc was wrong.
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: