Noobaa/Backingstore : Need facility to change labels #1489
+17
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to allow to modify the matchLabel of topologySpreadConstraints for noobaa's backingstore pods. https://issues.redhat.com/browse/DFBUGS-277 Signed-off-by: Ashish Pandey <aspandey@redhat.com>
aspandey
requested review from
achouhan09,
liranmauda,
shirady and
naveenpaul1
achouhan09
reviewed
Dec 23, 2024
| @@ -2,4 +2,6 @@ apiVersion: noobaa.io/v1alpha1 | |||
| kind: BackingStore | |||
| metadata: | |||
| name: default | |||
| labels: | |||
| backingstore: noobaa | |||
There was a problem hiding this comment.
I think we should avoid setting a default label for the BackingStore. Instead, users should have the flexibility to add the label as needed.
| @@ -1169,6 +1169,12 @@ func (r *Reconciler) needUpdate(pod *corev1.Pod) bool { | |||
| } | |||
| } | |||
|
|
|||
| var pod_label = pod.Labels["backingstore"] | |||
| var bs_label = r.BackingStore.Labels["backingstore"] | |||
There was a problem hiding this comment.
and we can check here if label is provided in backingstore then we will update the label in pv-pods.
| var pod_label = pod.Labels["backingstore"] | ||
| var bs_label = r.BackingStore.Labels["backingstore"] | ||
| if pod_label != bs_label { | ||
| return true |
There was a problem hiding this comment.
We should log a warn msg here if the label is updated
| @@ -1329,7 +1337,7 @@ func (r *Reconciler) updatePodTemplate() error { | |||
| NodeTaintsPolicy: &honor, | |||
| LabelSelector: &metav1.LabelSelector{ | |||
| MatchLabels: map[string]string{ | |||
| "backingstore": "noobaa", | |||
| "backingstore": bs_label, | |||
There was a problem hiding this comment.
Suggested change
| "backingstore": bs_label, | |
| "pvbackingstore": bs_label, |
wdyt? Can we change the label name to pvbackingstore ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to allow to modify the matchLabel of
topologySpreadConstraints for noobaa's backingstore pods.
https://issues.redhat.com/browse/DFBUGS-277
Testing -
1 - Create a backing store.
2 - Check the label for backingstore and also the pod
kubectl get backingstore my-backingstore -o yaml
kubectl describe pod my-backingstore-noobaa-pod-c2348d65
3 -
Change the label of a backingstore object like this -
kubectl label backingstore my-backingstore backingstore=noobaa-new --overwrite
This will trigger the reconciliation and the pod will be reinitialize and now have a "backingstore=noobaa-new" as label