Skip to content
This repository was archived by the owner on Jun 19, 2023. It is now read-only.

Added more fields to SlackUser from the user object #47

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions src/SlackConnector.Tests.Unit/Extensions/UserExtensionsTests.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
using NUnit.Framework;
using SlackConnector.Connections.Models;
using SlackConnector.Extensions;

namespace SlackConnector.Tests.Unit.Extensions {
[TestFixture]
public class UserExtensionsTests {
[Test]
public void should_create_slack_user_from_user() {
var user = new User {
Id = "Id",
Name = "Name",
TimeZoneOffset = 0L,
IsBot = false,
Deleted = false,
Presence = "active",
Profile = new Profile {
Email = "a@b.c",
FirstName = "First",
LastName = "Last",
Image = "http://image.com",
Title = "Developer"
}
};

var slackUser = user.ToSlackUser();

Assert.AreEqual(user.Id, slackUser.Id);
Assert.AreEqual(user.Name, slackUser.Name);
Assert.AreEqual(user.Profile.Email, slackUser.Email);
Assert.AreEqual(user.TimeZoneOffset, slackUser.TimeZoneOffset);
Assert.AreEqual(user.IsBot, slackUser.IsBot);
Assert.AreEqual(user.Profile.FirstName, slackUser.FirstName);
Assert.AreEqual(user.Profile.LastName, slackUser.LastName);
Assert.AreEqual(user.Profile.Image, slackUser.Image);
Assert.AreEqual(user.Profile.Title, slackUser.WhatIDo);
Assert.AreEqual(user.Deleted, slackUser.Deleted);
Assert.IsNotNull(slackUser.Online);
Assert.IsTrue(slackUser.Online.Value);
}

[Test]
public void should_create_slack_user_from_incomplete_user() {
var user = new User {Presence = "Away"};

var slackUser = user.ToSlackUser();

Assert.IsNotNull(slackUser.Online);
Assert.IsFalse(slackUser.Online.Value);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@
<Compile Include="Connections\Clients\Flurl\FlurlHandshakeClientTests.cs" />
<Compile Include="Connections\Clients\ResponseVerifierTests.cs" />
<Compile Include="Connections\ProxySettingsTests.cs" />
<Compile Include="Extensions\UserExtensionsTests.cs" />
<Compile Include="Models\SlackAttachmentSerialisationTests.cs" />
<Compile Include="Properties\AssemblyInfo.cs" />
<Compile Include="Resources\ResourceManager.cs" />
Expand Down
11 changes: 7 additions & 4 deletions src/SlackConnector/Connections/Models/Profile.cs
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
using Newtonsoft.Json;

namespace SlackConnector.Connections.Models
{
internal class Profile
{
namespace SlackConnector.Connections.Models {
internal class Profile {
[JsonProperty("first_name")]
public string FirstName { get; set; }

Expand All @@ -16,6 +14,11 @@ internal class Profile
[JsonProperty("real_name_normalized")]
public string RealNameNormalised { get; set; }

[JsonProperty("image_512")]
public string Image { get; set; }

public string Email { get; set; }

public string Title { get; set; }
}
}
7 changes: 6 additions & 1 deletion src/SlackConnector/Extensions/UserExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,12 @@ public static SlackUser ToSlackUser(this User user)
Name = user.Name,
Email = user.Profile?.Email,
TimeZoneOffset = user.TimeZoneOffset,
IsBot = user.IsBot
IsBot = user.IsBot,
FirstName = user.Profile?.FirstName,
LastName = user.Profile?.LastName,
Image = user.Profile?.Image,
WhatIDo = user.Profile?.Title,
Deleted = user.Deleted
};

if (!string.IsNullOrWhiteSpace(user.Presence))
Expand Down
5 changes: 5 additions & 0 deletions src/SlackConnector/Models/SlackUser.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ public class SlackUser
public string Id { get; set; }
public string Name { get; set; }
public string Email { get; set; }
public string FirstName { get; set; }
public string LastName { get; set; }
public string Image { get; set; }
public string WhatIDo { get; set; }
public bool Deleted { get; set; }

public string FormattedUserId
{
Expand Down