-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand Address Bar on wide screens, keep error box small #57
Open
hsuperman
wants to merge
77
commits into
noodlapp:main
Choose a base branch
from
hsuperman:navbar-expand
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated Fluxscape Icons
brightness fix
feat: Update branding
Co-authored-by: alan-x-n <x.alanan.x@gmail.com>
Co-authored-by: alan-x-n <x.alanan.x@gmail.com>
Co-authored-by: alan-x-n <x.alanan.x@gmail.com>
In some cases the error is a string, and when logging it will write "undefined" into the console instead of providing a useful error message.
* feat: Version control commit, View on GitHub * fix: MenuDialog allow undefined menu item This makes it a lot easier to create conditional menu items
* fix: branding info for package.json * fix: updated package jsons with updated contact & author info --------- Co-authored-by: alan-x-n <x.alanan.x@gmail.com>
This removes the initial visible layout shift
…de Functions dropdown (fluxscape#69)
Same behaviour as Query Record's "First Record Id"
…pe#73) * feat(runtime): Add "className" option support to "relatedTo" Also includes error handling when "className" is not found.
This occurred because building in dev mode does not create the source map files which it expects to copy over.
… node scope to fail (fluxscape#75)
…pe#78) TypeError: Cannot read properties of undefined (reading 'replace') at Object.onClosePopup (navigation.js:10:1) at EventEmitter.<anonymous> (nodecontext.js:491:1) at Object.onceWrapper (events.js:242:1) at EventEmitter.emit (events.js:153:1) at NoodlRuntime._doUpdate (noodl-runtime.js:338:1)
…scape#79) Adding support for some more options when fetching a record. https://github.com/parse-community/parse-server/blob/91f9aca25bc6212ae27aac7af328ee1f19f058c8/src/Routers/ClassesRouter.js#L60-L68
…ape#80) It is very nice to be able to inspect the value inside the variable even via the "Set Variable" node. Most of the time I see an additional variable node placed above the "Set Variable" node to just inspect the current value.
Error: "TypeError: Cannot read properties of undefined (reading 'replace')"
We cannot guarantee that this is always correct since there is repeaters and dynamic repeaters etc, but this can give a hint to how many times a component is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously on widescreens, the error bar grows wide while the address bar has a max width. This wastes space because the error box never needs to grow that wide, while the URL bar in theory can be arbitrarily long. This small change reverses the logic so that the address bar takes up the maximum width possible.