Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various QoL improvements for Circles #51

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Various QoL improvements for Circles #51

merged 4 commits into from
Oct 24, 2023

Conversation

cznrhubarb
Copy link

Motivation

There are a few painpoints in Circles I wanted to tackle for dev day.

Changes

  • Sending a DE/ES user to the STING dash, would send them to the EN STING dash. This has been corrected to send them to the appropriate dash now. (not pictured in the screenshots below)
  • Whether a user is in the STING dash or not is now on their profile in the form of a bee icon. If the user is not on the STING dash, there is no Bee icon.
  • Added the "look up user in Manatee/Dash" links to a user's profile actions.
  • Added the ability to reply to replies (sort of). You're still actually replying to the comment the original reply was to, but now it doesn't feel like you can't respond to people. We don't support infinite levels of replies, so this is the best we'll be able to do.

Testing Done

  • I have successfully ran the unit tests
  • I have successfully ran the integration tests
  • I have successfully completed the manual testing of my changes and the surrounding code

Screenshots

image
image
image

@cznrhubarb cznrhubarb requested a review from a team as a code owner October 23, 2023 20:50
vbradvica
vbradvica reviewed Oct 23, 2023
View reviewed changes
Copy link

@vbradvica vbradvica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

src/social/components/Comment/index.js Outdated Show resolved Hide resolved
src/social/components/Comment/index.js Outdated Show resolved Hide resolved
src/social/components/Sting/StingModal.tsx
@@ -52,10 +54,13 @@ export const StingModal = ({ userAccessCode, pathToContent, isOpen, onClose }: S
reset();
}, [isOpen]);

const { user }: { user: any } = useUser(userAccessCode);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use ReturnType<typeof useUser> here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't work because it knows about user, but not what's inside user
image

cznrhubarb and others added 3 commits October 23, 2023 17:21
@cznrhubarb cznrhubarb merged commit 4890793 into develop Oct 24, 2023
2 checks passed
@cznrhubarb cznrhubarb deleted the mike/dev-day-qol-improvements branch October 24, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbradvica vbradvica vbradvica left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cznrhubarb @vbradvica