-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/engagement #7
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, my guy 👍 👍
.github/ISSUE_TEMPLATE/feature.yaml
Outdated
name: 🔧 feature request | ||
title: "[Feature]: " | ||
description: "request the team work on new feature" | ||
labels: ["enhancement", "feature", "review"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about just feature and triage? Is "review" functioning like "triage" is on bugs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya, that makes sense, I actually did want the triage tag. @arbitrarytech I'm going to add a triage tag to our "defined set" if no concerns.
Co-authored-by: Nathaniel <314009+nathanielks@users.noreply.github.com>
few requested updates added, also confirmed the currently supported feature set doesn't provide for user-added options in select menus. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments about the limitations of the set list of multiple choice options (I realize you're already aware of this issue). Will let you know if come across any idea of how to address that situation.
I also left a comment about the CODE-OF-CONDUCT.md
doc needing to be customized for Noop. There are a bunch of Docker references in the current version of that file.
CODE-OF-CONDUCT.md
Outdated
|
||
This work is licensed under a Creative Commons Attribution 3.0 Unported License For attribution requirements: | ||
|
||
"@Docker Code of Conduct" © 2016 Docker, Inc, used under a Creative Commons Attribution Unported license: [http://creativecommons.org/licenses/by/3.0/](http://creativecommons.org/licenses/by/3.0/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should plan to go through and update this CODE-OF-CONDUCT.md
doc to be customized for Noop Inc before this PR is merged into main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...also confirmed the currently supported feature set doesn't provide for user-added options in select menus.
I think that's a pretty critical feature which we need to find a way to accommodate. The alternative is one of us needs to remember to regularly audit/adjust the hardwired options in this repo's issue templates which isn't ideal.
Switched to text area for version, removed required flag.
I think that's a pretty critical feature which we need to find a way to accommodate. The alternative is one of us needs to remember to regularly audit/adjust the hardwired options in this repo's issue templates which isn't ideal. |
NOTE:
community.wiki.git
and can be separately managed using standard git tools , however, the main branch is only ever rendered, so all commits (including development/changes) will need to go into main.