Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/engagement #7

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feature/engagement #7

wants to merge 12 commits into from

Conversation

apsamuel
Copy link

@apsamuel apsamuel commented Feb 2, 2022

  • adds issue template forms (bug & enhancement)
  • updates README
  • enables Wikis in settings

NOTE:

  • ⚠️ The wiki is a separate repository, eg. community.wiki.git and can be separately managed using standard git tools , however, the main branch is only ever rendered, so all commits (including development/changes) will need to go into main.

@apsamuel apsamuel marked this pull request as draft February 2, 2022 16:04
Copy link

@nathanielks nathanielks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, my guy 👍 👍

name: 🔧 feature request
title: "[Feature]: "
description: "request the team work on new feature"
labels: ["enhancement", "feature", "review"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about just feature and triage? Is "review" functioning like "triage" is on bugs?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya, that makes sense, I actually did want the triage tag. @arbitrarytech I'm going to add a triage tag to our "defined set" if no concerns.

apsamuel and others added 3 commits February 3, 2022 15:57
Co-authored-by: Nathaniel <314009+nathanielks@users.noreply.github.com>
@apsamuel apsamuel marked this pull request as ready for review February 23, 2022 16:32
@apsamuel
Copy link
Author

  • adds issue template forms (bug & enhancement)

  • updates README

  • enables Wikis in settings

NOTE:

  • ⚠️ The wiki is a separate repository, eg. community.wiki.git and can be separately managed using standard git tools , however, the main branch is only ever rendered, so all commits (including development/changes) will need to go into main.

few requested updates added, also confirmed the currently supported feature set doesn't provide for user-added options in select menus.

Copy link
Member

@derekwolpert derekwolpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments about the limitations of the set list of multiple choice options (I realize you're already aware of this issue). Will let you know if come across any idea of how to address that situation.

I also left a comment about the CODE-OF-CONDUCT.md doc needing to be customized for Noop. There are a bunch of Docker references in the current version of that file.


This work is licensed under a Creative Commons Attribution 3.0 Unported License For attribution requirements:

"@Docker Code of Conduct" © 2016 Docker, Inc, used under a Creative Commons Attribution Unported license: [http://creativecommons.org/licenses/by/3.0/](http://creativecommons.org/licenses/by/3.0/)
Copy link
Member

@derekwolpert derekwolpert Feb 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should plan to go through and update this CODE-OF-CONDUCT.md doc to be customized for Noop Inc before this PR is merged into main

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apsamuel

...also confirmed the currently supported feature set doesn't provide for user-added options in select menus.

I think that's a pretty critical feature which we need to find a way to accommodate. The alternative is one of us needs to remember to regularly audit/adjust the hardwired options in this repo's issue templates which isn't ideal.

Switched to text area for version, removed required flag.

@derekwolpert
Copy link
Member

derekwolpert commented Feb 24, 2022

@apsamuel

...also confirmed the currently supported feature set doesn't provide for user-added options in select menus.

I think that's a pretty critical feature which we need to find a way to accommodate. The alternative is one of us needs to remember to regularly audit/adjust the hardwired options in this repo's issue templates which isn't ideal.

@apsamuel apsamuel requested a review from derekwolpert March 22, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants