BUG-2097 fix read only #380
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #380 +/- ##
==========================================
+ Coverage 85.24% 85.26% +0.01%
==========================================
Files 98 98
Lines 10610 10609 -1
==========================================
+ Hits 9045 9046 +1
+ Misses 1565 1563 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
….spoke_role_is_read_only is true.
| @@ -165,6 +165,10 @@ async def apply_iam_templates( | |||
| :param templates: The list of templates to apply. | |||
| :param remote_worker: The remote worker to use for applying templates. | |||
| """ | |||
| if config.spoke_role_is_read_only: | |||
| log.critical("Unable to apply resources when spoke_role_is_read_only is True") | |||
| return [] | |||
There was a problem hiding this comment.
should we raise an error instead? I guess we don't want to raise because we don't want to interrupt the other plugins?
There was a problem hiding this comment.
yeah I didn't want AWS to interrupt execution of other providers. Ideally we should return template change details with the exception in each instance but the way we output proposed changes will need to be updated and didn't want the ticket to go down a rabbit hole.
Created an issue that will allow us to assign provider wide exceptions #382
There was a problem hiding this comment.
yea, its an aspect of provider isolation in apply. because if okta has a service outage, I still want AWS to work.
What changed?
Additional notes
The reason for moving larger prompts from questionary to click.echo is due to the issues questionary has with large strings. Text is frequently truncated and if you resize the terminal the text will occasionally be duplicated. The strings in click.echo are prefixed with a new line for readability. It creates a visual grouping of the click text with the questionary prompt. We could consider moving away from questionary in the future but this solves the problem until then.
How was it tested?
If it was manually verified, list the instructions for your reviewers to follow.