Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address part of #490. Name the hyperlink with more details #549

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

smoy
Copy link
Contributor

@smoy smoy commented Aug 5, 2023

What changed?

  • Instead of [Run], name it [Extended Plan Details]
  • If we don't have a valid url, don't include the fragment

Rationale

  • Don't include the html if it's not valid.

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

  • Unit Tests
  • Functional Tests
  • Manually Verified

* If we don't have a valid url, don't include the fragment
@smoy smoy self-assigned this Aug 5, 2023
Copy link
Contributor

@castrapel castrapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.04% ⚠️

Comparison is base (9f356f9) 83.77% compared to head (5fea957) 83.74%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
- Coverage   83.77%   83.74%   -0.04%     
==========================================
  Files         105      105              
  Lines       12206    12209       +3     
==========================================
- Hits        10226    10224       -2     
- Misses       1980     1985       +5     
Flag Coverage Δ
functional_tests 65.91% <0.00%> (-0.18%) ⬇️
functional_tests_config_discovery 46.03% <0.00%> (-0.02%) ⬇️
unit_tests 73.99% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
iambic/plugins/v0_1_0/github/github.py 63.36% <75.00%> (+0.02%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smoy smoy merged commit 179360b into main Aug 5, 2023
@smoy smoy deleted the fix/no_run_link branch August 5, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants