Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #600 Assert against non-sensible excluded_accounts #601

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

smoy
Copy link
Contributor

@smoy smoy commented Aug 21, 2023

What changed?

  • Assert against non-sensible excluded_accounts

Rationale

  • During import phase, we don't want to generate non-sensible excluded_accounts. If it's a new template, import logic does not know how to generate exclude_accounts. If there is an existing template, the best it can do if old template doesn't have exclude_account, it shouldn't add new excluded_accounts.

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

  • Unit Tests
  • Functional Tests
  • Manually Verified

Relying existing test suite.

@smoy smoy self-assigned this Aug 21, 2023
castrapel
castrapel previously approved these changes Aug 21, 2023
Copy link
Contributor

@castrapel castrapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -9.75% ⚠️

Comparison is base (e3f5f0c) 83.01% compared to head (3c5ed76) 73.27%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
- Coverage   83.01%   73.27%   -9.75%     
==========================================
  Files         105      105              
  Lines       12549    12560      +11     
==========================================
- Hits        10418     9203    -1215     
- Misses       2131     3357    +1226     
Flag Coverage Δ
functional_tests ?
functional_tests_config_discovery ?
unit_tests 73.27% <33.33%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
iambic/core/template_generation.py 84.84% <33.33%> (-6.84%) ⬇️

... and 49 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants