Add extmarks inserter #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When moving backward to a previous variable, don't replace it with its default value if it's already been resolved. Also reset any unresolved variables back to their placeholder values. This commit also contains some minor refactoring and comment additions.
I copied this from the text_markers inserter, but I don't think it's actually necessary. The anonymous transformations are expanded in the first called to 'evaluator.evaluate_structure', and since they don't depend on any other input variables we can go ahead and just expand them and insert them right at the beginning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt at an extmarks inserter. I started a new PR instead of simply reopening #31 because apparently GitHub doesn't allow you to change the source branch of a PR, and I didn't want the PR to be against
masterof my fork.In my opinion, this implementation is much stronger than the original. It also features live-updating, so that as you type in a value for a variable, all other instances of that variable are updated in real-time.