Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Release): Remove npm audit signatures command #735

Closed
wants to merge 2 commits into from
Closed

fix(Release): Remove npm audit signatures command #735

wants to merge 2 commits into from

Conversation

dominpn
Copy link
Member

@dominpn dominpn commented Feb 7, 2025 •
edited
Loading

What

Screenshot 2025-02-07 at 13 36 15

Testing

  • Is this change covered by the unit tests?

  • Is this change covered by the integration tests?

  • Is this change covered by the automated acceptance tests? (if applicable)

Compatibility

  • Does this change maintain backward compatibility?

Screenshots

Before

N/A

After

N/A

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dominpn dominpn changed the title Fix release fix(Release): Remove npm audit signatures Feb 7, 2025
@dominpn dominpn changed the title fix(Release): Remove npm audit signatures fix(Release): Remove npm audit signatures command Feb 7, 2025
@dominpn dominpn marked this pull request as ready for review February 7, 2025 12:41
@dominpn dominpn requested a review from a team as a code owner February 7, 2025 12:41
@dominpn dominpn requested review from raczyk and petesiudak February 7, 2025 12:41
@aws-amplify-eu-west-1 AWS Amplify (eu-west-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-735.du3gff836giqw.amplifyapp.com

jaknb
jaknb approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@jaknb jaknb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Is @mescam aware of this?

mescam
mescam approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@mescam mescam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this as a temporary measure, but we should find a solution to bring this back as soon as possible. Please do not forget.

@dominpn dominpn marked this pull request as draft February 11, 2025 10:27
@dominpn
Copy link
Member Author

dominpn commented Feb 11, 2025

Bumping Node version should resolve the issue
#736

@dominpn dominpn closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mescam mescam mescam approved these changes

@jaknb jaknb jaknb approved these changes

@gzgsck gzgsck gzgsck approved these changes

@raczyk raczyk Awaiting requested review from raczyk raczyk is a code owner automatically assigned from nordcloud/core-frontend-reviewers

@petesiudak petesiudak Awaiting requested review from petesiudak petesiudak is a code owner automatically assigned from nordcloud/core-frontend-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dominpn @mescam @jaknb @gzgsck