Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from jitsi:master #36

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[pull] master from jitsi:master #36

wants to merge 6 commits into from

Conversation

pull[bot]
Copy link

@pull pull bot commented Sep 13, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

)

* feat(transcription): Drops TranscriberManager and expects dialIQ.

* feat(transcription,recording): Adds option to disable moderator checks.

Default behavior is not changed.

* ref: Remove unused transcription code.

* feat(transcription): Returns an error if transcriber is already in room.

* squash: Fixes comments.

---------

Co-authored-by: Boris Grozev <boris@jitsi.org>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 34.61538% with 17 lines in your changes missing coverage. Please review.

Project coverage is 27.56%. Comparing base (cd6901a) to head (5cba140).

Files with missing lines Patch % Lines
...in/kotlin/org/jitsi/jicofo/xmpp/JigasiIqHandler.kt 38.46% 7 Missing and 1 partial ⚠️
...rc/main/kotlin/org/jitsi/jicofo/jibri/BaseJibri.kt 0.00% 4 Missing ⚠️
...tsi/jicofo/conference/JitsiMeetConferenceImpl.java 0.00% 3 Missing ⚠️
...n/kotlin/org/jitsi/jicofo/jigasi/JigasiDetector.kt 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #36      +/-   ##
============================================
+ Coverage     27.50%   27.56%   +0.05%     
+ Complexity      478      474       -4     
============================================
  Files           130      129       -1     
  Lines          8028     7942      -86     
  Branches       1109     1099      -10     
============================================
- Hits           2208     2189      -19     
+ Misses         5546     5476      -70     
- Partials        274      277       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull pull bot added the ⤵️ pull label Sep 13, 2024
bgrozev and others added 4 commits September 18, 2024 11:54
* feat: Verify the rayo JvbRoomName header if it exists.

* squash: Use the correct room JID.
Generate left/kicked events internally. In the future we want different
handling based on content of the presence which we can't do with
ParticipantStatusListener. Plus, we've had problems with them executing
in inconsistent order.
…es to breakout room. (#1169)

* fix(breakout-rooms): Fixes the case where a single participant switches to breakout room.

We keep around conferences when there is a breakout room. When a single participant is switching we first get participant left then breakout room is created, so we need to distinguish that the participant left is for joining breakout room.

* squash: Fixes tests.

* squash: Doc update
…1170)

* fix(visitors): Make sure we disconnect vnodes before leaving rooms.

Use case is a single main participant and a visitor node. If jicofo leaves visitor room before disconnecting, the client will reload seeing jicofo leaving. If we disconnect first, we destroy the room with an appropriate message shown to visitors.

* squash: synchronize, refactor.

---------

Co-authored-by: Boris Grozev <boris@jitsi.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants