build(npmrc): Explicitly configure the Node version to use #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschuberth
commented
May 28, 2024
| @@ -1,4 +1,5 @@ | |||
| # pnpm-related options | |||
| shamefully-hoist=true | |||
| strict-peer-dependencies=false | |||
| engine-strict = true | |||
| engine-strict=true | |||
| use-node-version=20.13.1 | |||
There was a problem hiding this comment.
I'm open to using a different version here according to your preferences @petkivim!
There was a problem hiding this comment.
Hi @sschuberth!
Node version is already managed by gradle plugin here, version number is defined in gradle.properties.
Setting use-node-version here would cause it to download again even when using the same version number for gradle plugin.
There was a problem hiding this comment.
I see. Maintaining the version in two places would not be nice anyway. I'll try to think of another approach to make the ORT analyzer use the correct Node version.
sschuberth
force-pushed
the
use-node-version
branch
from
98bee7a
to
e61425c
Compare
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
While `package.json` files have `engines.node` set, that specifies a range of compatible runtime Node versions, but not the exact version to build the project. Use `pnpm`'s `use-node-version` directive [1] for that purpose. Choose the latest 20 version that still matches `engines.node`. [1]: https://pnpm.io/npmrc#use-node-version Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
sschuberth
force-pushed
the
use-node-version
branch
from
e61425c
to
ecb35df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
package.jsonfiles haveengines.nodeset, that specifies a range of compatible runtime Node versions, but not the exact version to build the project.Choose the current version from the 20 branch.