v2 - Rewrite to TypeScript with generated types #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilianalillyy
force-pushed
the
master
branch
6 times, most recently
from
5315562 to
e583c19
Compare
|
Hey, is there any progress? Currently dealing with an error in my Remix app regarding missing declaration files. Thanks |
had the same issue, you can use @lilianaa/nordigen-node for now, which is what's in this PR |
|
@lilianalillyy alright, will give that a shot, thanks! |
|
@lilianalillyy thank you!! |
- Adds types for requests and responses generated from the Swagger schema - Uses Vite for build - Removes need for babel in favor of ts-jest in tests - Added `countries` as there is (to my knowledge) no endpoint to get all available countries
- Enums seems to have been removed from the Swagger spec, however they were kept and are now in `src/types/enums.ts`
|
rebased with master & released @lilianaa/nordigen-node@2.0.0-7 |
np, don't forget to update to 2.0.0-7, it's up to date with current changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues & PRs
closes PR #44
fixes issues #47, #48, #51
Proposed Changes
countriesas there is (to my knowledge) no endpoint to get all available countries