Skip to content
This repository has been archived by the owner on Oct 1, 2018. It is now read-only.

Fix for issue #110 - support for Cordova 7.0 #122

Closed
wants to merge 2 commits into from

Conversation

martindrapeau
Copy link

No description provided.

@ccorcos
Copy link

ccorcos commented Aug 1, 2017

@nikDemyankov can you take a look at this PR?

@sam2x
Copy link

sam2x commented Aug 7, 2017

Please merge this. The current code is breaking all cordova build project which want to use last cordova version. This patch is fixing it. Thanks for it @martindrapeau

@ccorcos
Copy link

ccorcos commented Aug 7, 2017

@sam2x you can just pull this branch in the meantime:

	<plugin name="cordova-universal-links-plugin" spec="https://github.com/nordnet/cordova-universal-links-plugin#22225179a5debfcff801e306eb1bf5477200aeda" />

@ccorcos
Copy link

ccorcos commented Aug 22, 2017

@nikDemyankov whats taking so long?

@ben-kn-app
Copy link

Hi @ccorcos, I can't add your branch

<plugin name="cordova-universal-links-plugin" spec="https://github.com/nordnet/cordova-universal-links-plugin#22225179a5debfcff801e306eb1bf5477200aeda" />

it gives the following error:
fatal: reference is not a tree: 22225179a5debfcff801e306eb1bf5477200aeda

Any other way to add this branch?

@ccorcos
Copy link

ccorcos commented Sep 1, 2017

sorry, wrong username:

<plugin name="cordova-universal-links-plugin" spec="https://github.com/martindrapeau/cordova-universal-links-plugin#22225179a5debfcff801e306eb1bf5477200aeda" />

@ccorcos
Copy link

ccorcos commented Sep 19, 2017

Lets do this @nikDemyankov

kiliankoller pushed a commit to kiliankoller/cordova-universal-links-plugin that referenced this pull request Sep 27, 2017
@mix3d
Copy link

mix3d commented Oct 16, 2017

Is this commit better than PR #114?

@musemind
Copy link

This made me crazy working with Meteor, I had to change the file on every build when switching between branches. I forked the repo and made the changed of this pull request.

Feel free to use it cordova-universal-links-plugin-fix@1.2.1 (-fix suffix) for a quickfix.
https://www.npmjs.com/package/cordova-universal-links-plugin-fix

@nordnet-deprecation-bot
Copy link
Contributor

👋 Hi! Thank you for your interest in this repo.

😢 We are not using nordnet/cordova-universal-links-plugin anymore, and we lack the manpower and the experience needed to maintain it. We are aware of the inconveniece that this may cause you. Feel free to use it as is, or create your own fork.

🔒 This will now be closed & locked.

ℹ️ Please see #160 for more information.

@nordnet nordnet locked and limited conversation to collaborators Sep 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants