Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

Fix styling on select input #219

Closed
geordidearns opened this issue May 15, 2017 · 5 comments
Closed

Fix styling on select input #219

geordidearns opened this issue May 15, 2017 · 5 comments
Assignees
@bstream

Comments

@geordidearns
Copy link
Contributor

Hi,

Just a few styling issues on the select input: will attach images and explain.
screen shot 2017-05-15 at 17 00 06

This happens with long names, here is the fix for it:
screen shot 2017-05-15 at 16 55 52

also removing the 'pxm' on the padding-right on this, as it's invalid
screen shot 2017-05-15 at 17 01 38

Thanks :)
@geordidearns
Copy link
Contributor Author

Tagging for reference @bstream @willeeklund

@geordidearns
Copy link
Contributor Author

Also, it would be awesome to support this attribute: https://www.w3schools.com/tags/att_global_title.asp

Which would allow the long truncated names to be shown in full on hover. Please ask any questions if you have any

@JCB-K
Copy link
Contributor

JCB-K commented May 15, 2017

@geordidearns text-overflow: ellipsis would in this case hide the account number. Is that acceptable behaviour?

For reference, pxm typo is here: https://github.com/nordnet/nordnet-ui-kit/blame/master/src/components/input/input-select-styles.jsx#L23

@iamstarkov
Copy link
Member

text-overflow is a nice suggestion

@iamstarkov
Copy link
Member

i would say we go with white-space: nowrap, text-overflow: ellipsis and a bit padding-right magic
screen shot 2017-05-15 at 9 41 57 pm

@bstream bstream self-assigned this May 16, 2017
bstream pushed a commit that referenced this issue May 16, 2017
fix: styling of select input. Fixes #219
292f45f
bstream pushed a commit that referenced this issue May 17, 2017
fix: release flow
d4338d0 
chore: Try to fix deploying package & gh-pages via travis
chore: Add coverage target
fix: styling of select input. Fixes #219 (#221)
fix: remove broken file
fix: Set pointer-events to none on icons (#217)
fix: change circle arrow (#218)
fix: Remove default marginBottom (#216)
fix: addonRight for small input fields (#215)
fix: Add new modifier to proptypes (#214)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bstream bstream

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@iamstarkov @JCB-K @bstream @geordidearns