Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

Dropdown test #490

Merged
merged 7 commits into from
Dec 21, 2018
Merged

Dropdown test #490

merged 7 commits into from
Dec 21, 2018

Conversation

Myoxocephalus
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 83.535% when pulling 07b0298 on Myoxocephalus:dropdown-test into 9416c05 on nordnet:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 83.535% when pulling 07b0298 on Myoxocephalus:dropdown-test into 9416c05 on nordnet:master.

@coveralls
Copy link

coveralls commented Dec 20, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 83.842% when pulling d68664b on Myoxocephalus:dropdown-test into 0b98933 on nordnet:master.

JacobBlomgren
JacobBlomgren approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@JacobBlomgren JacobBlomgren left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm reminded now that we should probably mark this whole component as deprecated in favor of PopupMenu – its accessible cousin.

@JacobBlomgren JacobBlomgren merged commit 8ab2874 into nordnet:master Dec 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JacobBlomgren JacobBlomgren JacobBlomgren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Myoxocephalus @coveralls @JacobBlomgren