Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

fix(editableinput): removes fixed size for editbutton on editableinput #583

Merged

Conversation

anneback
Copy link
Contributor

No description provided.

@anneback anneback requested a review from KitsuneKelso March 14, 2019 16:08
@vercel
Copy link

vercel bot commented Mar 14, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@anneback anneback merged commit 585e014 into master Mar 14, 2019
@JacobBlomgren
Copy link
Contributor

@anneback Since there was no description, might I just ask what the bug fix was? I tried to replicate how it was before, and the icon seems smaller with this change. It's definitely an OK PR and all, I'm just trying to gather what the purpose was?

@KitsuneKelso
Copy link
Contributor

KitsuneKelso commented Mar 15, 2019

@anneback Since there was no description, might I just ask what the bug fix was? I tried to replicate how it was before, and the icon seems smaller with this change. It's definitely an OK PR and all, I'm just trying to gather what the purpose was?

@JacobBlomgren the problem was that the edit button was getting an oval shape when the width and height were being set as they were. The other places where we use the edit button it's always styled without setting a width or height, so we needed this one to match them, as well as get rid of the non-perfect roundness.

This is what it looked like before the fix:

Screenshot 2019-03-15 at 08 52 46

Compare it to the button a bit further down in the image, that one is without any size adjustments.

@JacobBlomgren
Copy link
Contributor

@KitsuneKelso thank you, super clear description! good catch

@nordnet-release
Copy link
Member

🎉 This PR is included in version 4.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamstarkov iamstarkov deleted the bugfix/removed-fixed-size-for-editbutton-on-editableinput branch October 7, 2019 19:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants