This repository has been archived by the owner on Oct 20, 2022. It is now read-only.
fix: make style not override developers code #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjmonline
requested review from
iamstarkov,
Dhq,
shmidt-i,
jesperwiner,
KitsuneKelso,
jauniuse and
sievertknorrblad
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://nordnet-ui-kit-git-fix-typography-media-queries.nordnet1.now.sh |
Codecov Report
@@ Coverage Diff @@
## master #635 +/- ##
=======================================
Coverage 84.03% 84.03%
=======================================
Files 213 213
Lines 1560 1560
Branches 296 296
=======================================
Hits 1311 1311
Misses 214 214
Partials 35 35 |
sievertknorrblad
approved these changes
Jun 27, 2019
|
🎉 This PR is included in version 5.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we changed the mobile breakpoint of typography the media query was overriding the developers media query and vice versa depending on order