Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment Color Brightness #61

Merged
merged 2 commits into from
May 12, 2019
Merged

Comment Color Brightness #61

merged 2 commits into from
May 12, 2019

Commits on May 12, 2019

  1. Deprecate "Custom Comment Contrast" setting with warning notification 

    Removed the logic for the theme setting and added logic to show a
deprecation notification when the user has set a value larger than 0.
Also removed the Less CSS styles to adapt to the configured value.

GH-60
    @arcticicestudio
    arcticicestudio committed May 12, 2019
    Configuration menu
    Copy the full SHA
    0be34cc View commit details
    Browse the repository at this point in the history

  2. Comment Color Brightness 

    -> Please see nordtheme/nord#94 for all
   details about this design change decision.

Increased the comment color (`nord3`) brightness by 10% from a lightness
level of ~35% to ~45%.

This change also deprecates the "Custom Comment Contrast" theme setting.
It is not necessary anymore for users to increase the brightness on
their own when the default color has been increased by default.
A deprecation warning will be shown to notify all users who have set a
custom value for the configuration variable.

GH-60
    @arcticicestudio
    arcticicestudio committed May 12, 2019
    Configuration menu
    Copy the full SHA
    09333c3 View commit details
    Browse the repository at this point in the history