Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add padding inside GitHub and Git buttons in status bar #86

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add padding inside GitHub and Git buttons in status bar #86

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 1, 2020

Previously, there was no left and right padding inside the GitHub and Git buttons in the status bar.

Before
Before Padding Fix

After
After Padding Fix

Add padding inside GitHub and Git buttons in status bar
9ea9147 
Previously, there was no left and right padding inside the GitHub and Git buttons in the status bar.
moonwitch
moonwitch approved these changes Mar 27, 2020
View reviewed changes
Copy link

@moonwitch moonwitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These do work just fine

@arcticicestudio
Copy link
Contributor

Hi @MohamedAlFahim 👋, thanks for your contribution 👍

I've also planned to support the official GitHub package like documented in #67 and there's also PR #85 by @vprigent. I'll review #85 and check if this change is already provided, otherwise we can happily merge your PR too 😄

@arcticicestudio arcticicestudio self-assigned this Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcticicestudio arcticicestudio Awaiting requested review from arcticicestudio

@svengreb svengreb Awaiting requested review from svengreb svengreb is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees

@arcticicestudio arcticicestudio

Labels
context-package-support scope-compatibility scope-quality status-pending type-improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arcticicestudio @moonwitch