-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please normalize the license file #40
Conversation
Rename it from LICENSE.md to LICENSE and remove the markdown. Also add a License header keyword to nord-emacs.el. This helps tools that try to automatically detect the license (such as those used by Github and the Emacsmirror) to do their job.
Friendly ping! |
Sorry for the delay, haven't got much free time to work on my projects. Is there a specific reason why the Emacsmirror algorithm is not able to detect files with a Anyway, the documentation also says the file can be named |
Actually that should work too, but something appears to go wrong. I suspect that your copy of the license is too different from the vanilla version in some way for I extract license information from a package's "main library" using my own (rather crappy) code. But if that fails I also use The easiest fix as far as my needs are concerned, would be to just add this line to the library header: ;;; License: Apache-2.0 Thanks! |
Thanks for your explanation 👍 I'll go ahead and add the line to the theme if the changes to the Would be nice if you'd let me know if it works afterwards. |
Superseded by #41 |
Thanks! When will this change be merged into |
Actually, I think I should just mirror |
The project uses the gitflow branching model, so the I've got a free day today, actually working on some port projects and hope to implement a feature (theme config) today, so maybe there will be a new release today in |
Rename it from LICENSE.md to LICENSE and remove the markdown.
Also add a License header keyword to nord-emacs.el.
This helps tools that try to automatically detect the license
(such as those used by Github and the Emacsmirror) to do their
job.
Thanks for considering this.