Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add perspective.el support #91

Merged
merged 2 commits into from
Jun 20, 2020
Merged

Add perspective.el support #91

merged 2 commits into from
Jun 20, 2020

Conversation

kaiwk
Copy link
Contributor

@kaiwk kaiwk commented Jan 11, 2020

see: #86

@arcticicestudio
Copy link
Contributor

Hi @kaiwk 👋, thanks for your contribution 👍
I'll review the changes in the near future and get back to you.

@arcticicestudio arcticicestudio added this to the Next milestone Jun 16, 2020
arcticicestudio
arcticicestudio requested changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@arcticicestudio arcticicestudio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kaiwk 👋, thanks for your contribution 👍

I've reviewed the change and added a suggestion to make it more conform with the overall theme ambience.

@kaiwk kaiwk closed this Jun 19, 2020
svengreb
svengreb previously approved these changes Jun 20, 2020
View reviewed changes
arcticicestudio
arcticicestudio previously approved these changes Jun 20, 2020
View reviewed changes
Copy link
Contributor

@arcticicestudio arcticicestudio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess based on your 👍 reaction on my suggestion your fine with the change 😄
I'll rebase and merge it to include it in the next release version, thanks again for your contribution.

kaiwk and others added 2 commits June 20, 2020 13:18
@kaiwk @arcticicestudio
Add perspective.el support
12e56ce 
see: nordtheme#86
@svengreb @arcticicestudio
Use nord8 as foreground color for perspective.el
665a816 
using `nord8` as foreground color makes it consistent with the default status bar style.

Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com>
@arcticicestudio arcticicestudio dismissed stale reviews from svengreb and themself via 665a816 June 20, 2020 11:18
@arcticicestudio arcticicestudio merged commit 4f5b646 into nordtheme:develop Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcticicestudio arcticicestudio arcticicestudio approved these changes

@svengreb svengreb svengreb approved these changes

Assignees
No one assigned
Labels
context-package-support scope-compatibility type-feature
Projects
None yet
Milestone
version-next
Development

Successfully merging this pull request may close these issues.
3 participants
@kaiwk @arcticicestudio @svengreb