Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream theme to Guake #6

Open
gsemet opened this issue Apr 8, 2018 · 4 comments
Open

Upstream theme to Guake #6

gsemet opened this issue Apr 8, 2018 · 4 comments

Comments

@gsemet
Copy link

gsemet commented Apr 8, 2018

Hello, I am the Guake maintainer. I would be happy to see your theme integrated directly in Guake. Do not hesitate to add it in palettes.py ! I am not sure your script still works with Guake 3 since we rely on dconf and no more gconf.

Thanks for using Guake.

@arcticicestudio
Copy link
Contributor

Thanks for the request, I'll submit a PR to add it to palettes.py and test the install script with the latest version. Using dconf is a good decision so I can simply copy over the install script from the Nord GNOME Terminal project 😄
I think I'll keep the current script and rename it to something with -legacy so users running distros the new version isn't available yet can still install the theme.

@arcticicestudio
Copy link
Contributor

@gsemet I've submitted Guake/guake/pull/1275 which adds Nord to the palettes.

gsemet pushed a commit to Guake/guake that referenced this issue Apr 14, 2018
@mati865
Copy link

mati865 commented Jul 2, 2018

I believe this can be closed now.

@arcticicestudio
Copy link
Contributor

@mati865 Thanks for your notice to clean up issues, but the install script hasn't been ported to dconf yet and this ticket will be used to track the implementation. It'll be closed automatically as soon as the associated PR is merged.

@arcticicestudio arcticicestudio removed their assignment Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants