Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit support for bundled PhpStorm language syntax #153

Merged

Conversation

arcticicestudio
Copy link
Contributor

@arcticicestudio arcticicestudio commented Apr 27, 2020

Related to #120, #121
Closes #151


PhpStorm ships with support for specific languages, frameworks and libraries for PHP development and of course advanced highlighting for PHP itself. Due to the same problems like documented in #120 (mitigated in #121) some syntax theme keys required to be replaced with explicit definitions instead of relying on color inheritances.

Therefore this PR adds explicit support for PhpStorm's bundled language syntax:

  1. Main support for PHP and the official JetBrains plugin
  2. Laravel "Blade" Templates
    See JetBrains official “Blade“ documentation and the plugin for more details.
  3. "Twig" template engine
    See JetBrains official “Twig“ documentation and the plugin for more details.
  4. "Smarty" templates
    See JetBrains official “Smarty“ documentation for more details.

PHP syntax highlighting before and after

Blade syntax highlighting before and after

Twig syntax highlighting before and after

Smarty syntax highlighting before and after

PhpStorm [1] ships with support for specific languages, frameworks and
libraries for PHP development and of course advanced highlighting for
PHP. Due to the same problems documented in GH-120 (and mitigated in
GH-121) some syntax theme keys required to be replaced with explicit
definitions instead of reyling on color inheritances.

Therefore this commit adds explicit support for PhpStorm's bundled
language syntax:

1. Main support for "PHP" [2][3]
2. Laravel "Blade" Temapltes [4][5][6]
3. "Twig" template engine [7][8][9]
4. "Smarty" templates [10][11]

[1]: https://www.jetbrains.com/phpstorm
[2]: https://www.php.net
[3]: https://plugins.jetbrains.com/plugin/6610-php
[4]: https://laravel.com/docs/7.x/blade
[5]: https://www.jetbrains.com/help/phpstorm/blade-page.html
[6]: https://plugins.jetbrains.com/plugin/7569-blade
[7]: https://twig.symfony.com
[8]: https://www.jetbrains.com/help/phpstorm/symfony-twig.html
[9]: https://plugins.jetbrains.com/plugin/7303-twig
[10]: https://www.smarty.net
[11]: https://www.jetbrains.com/help/phpstorm/smarty.html

Related to GH-120,GH-121
GH-151

Co-authored-by: Sven Greb <development@svengreb.de>
@arcticicestudio arcticicestudio merged commit 9fa9d9a into develop Apr 28, 2020
@arcticicestudio arcticicestudio deleted the feature/gh-151-support-bundled-phpstorm-syntax branch April 28, 2020 06:15
@MatyCZ
Copy link

MatyCZ commented Aug 25, 2020

Is there any ETA for releasing 0.12? This changes are waiting too long. 😉

@arcticicestudio
Copy link
Contributor Author

@MatyCZ For almost all port projects it's always a question about finding time to write the release notes, prepare the version and deploy it to the publishing system. I've planned to release some new port projects on Friday, but no later than Saturday if it doesn't work out.

arcticicestudio added a commit that referenced this pull request Sep 22, 2020
Add explicit support for bundled PhpStorm language syntax

PhpStorm [1] ships with support for specific languages, frameworks and
libraries for PHP development and of course advanced highlighting for
PHP. Due to the same problems documented in GH-120 (and mitigated in
GH-121) some syntax theme keys required to be replaced with explicit
definitions instead of relying on color inheritances.

Therefore this commit adds explicit support for PhpStorm's bundled
language syntax:

1. Main support for "PHP" [2] and the official JetBrains plugin [3]
2. Laravel "Blade" Templates [4]
   See JetBrains official "Blade" documentation [5] and the plugin [6]
   for more details.
3. "Twig" template engine [7]
   See JetBrains official "Twig" documentation [8] and the plugin [9]
   for more details.
4. "Smarty" templates [10]
   See JetBrains official "Smarty" documentation [11] for more details.

[1]: https://www.jetbrains.com/phpstorm
[2]: https://www.php.net
[3]: https://plugins.jetbrains.com/plugin/6610-php
[4]: https://laravel.com/docs/7.x/blade
[5]: https://www.jetbrains.com/help/phpstorm/blade-page.html
[6]: https://plugins.jetbrains.com/plugin/7569-blade
[7]: https://twig.symfony.com
[8]: https://www.jetbrains.com/help/phpstorm/symfony-twig.html
[9]: https://plugins.jetbrains.com/plugin/7303-twig
[10]: https://www.smarty.net
[11]: https://www.jetbrains.com/help/phpstorm/smarty.html

Related to GH-120, GH-121
Closes GH-151

Co-authored-by: Sven Greb <development@svengreb.de>
@arcticicestudio
Copy link
Contributor Author

@MatyCZ Sorry, missed to push the update before my holidays. Anyway, version 0.12.0 is now available and shipped to the JetBrains Plugin Registry. The update is currently processed and should be available within the next 24h from Nord's plugin page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong variable color in PHPStorm
3 participants