Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update background under context menu separator #192

Merged
merged 1 commit into from
Feb 5, 2022

Conversation

dikoval
Copy link
Contributor

@dikoval dikoval commented Jan 6, 2022

Update background under context menu separator to make sure, that it matches overall menu background.

Before:
2022-01-06_10-50-02

After:
2022-01-06_10-51-25

P.S. JetBrains documentation mentions, that PopupMenu.background is responsible for "Background under the context or the main menu separators", but I haven't noticed any issues with main menu before/any changes after my commit.

Closes #190

Update background under context menu separator
to make sure, that it matches overall menu background.

Closes nordtheme#190
@arcticicestudio
Copy link
Contributor

Hi @dikoval 👋, thanks for your contribution 👍
I'll try to test and review the changes within the next week(s).

Copy link
Contributor

@arcticicestudio arcticicestudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, this makes menus appear way smoother.
Thanks again 🚀

@arcticicestudio
Copy link
Contributor

Release note & changelog assets

Before

After

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Background of menu items is different to popup window.
3 participants