Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pop-up menu colors #324

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amarakon
Copy link

@amarakon amarakon commented Sep 7, 2022

There are three areas in which I improved the pop-up menu colors:

  1. The background color is darker but still not as dark as the terminal background color, making it easier to notice the selected item.
  2. The foreground color for selected items remains unchanged because it is not needed to notice the selected item because of the above change.
  3. Since the background color is now darker, you can actually notice the scrollbar on the right if it exists.

Before and After

It looks a lot better in my opinion.

@svengreb
Copy link
Member

Thank you for your patience! 🙏🏼
It‘s been a while since I had free time to focus more on Nord, and my open source projects in general, and invest time in this issue due to work-life balance.

I recently published the first “Northern Post — The state and roadmap of Nord“ announcement which includes all details about the plans and future of the Nord project, including the goal of catching up with the backlog. This issue is part of the backlog and therefore I want to triage and process it to get one step closer to a “clean state“. Read the announcement about reaching the “clean“ contribution triage state in Nord‘s discussions for more details about the goal.

Therefore it has been added for triage in the central and single-source-of-truth project board that is also described in more detail in the roadmap announcement.


@amarakon Thanks for your contribution 🚀
The pull request has been added for triage and the review will be planned for the next iterations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: triage
Development

Successfully merging this pull request may close these issues.

2 participants