Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint-staged #133

Closed
2 tasks done
arcticicestudio opened this issue May 25, 2019 · 0 comments
Closed
2 tasks done

lint-staged #133

arcticicestudio opened this issue May 25, 2019 · 0 comments

Comments

@arcticicestudio
Copy link
Contributor

arcticicestudio commented May 25, 2019

Must be resolved before #133

Integrate lint-staged to run linters against staged Git files to prevent to add code that violates any style guide into the code base.

Configuration

The configuration file lint-staged.config.js will be placed in the project root and includes the command that should be run for matching file extensions (globs). It will include at least the three following entries with the same order as listed here:

  1. prettier --list-different - Run Prettier against *.{js,json,mdx,yml} to ensure all files are formatted correctly. The --list-different prints the found files that are not conform to the Prettier configuration.
  2. eslint - Run ESLint against *.{js,json} to ensure all JavaScript files are compliant to the style guide after being formatted with Prettier.
  3. remark --no-stdout - Run remark-lint against *.md to ensure all Markdown files are compliant to the style guide. The --no-stdout flag suppresses the output of the parsed file content.

Tasks

  • Install lint-staged package.
  • Implement lint-staged.config.js configuration file.
@arcticicestudio arcticicestudio added this to the 0.9.0 milestone May 25, 2019
@arcticicestudio arcticicestudio self-assigned this May 25, 2019
@arcticicestudio arcticicestudio removed their assignment May 25, 2019
arcticicestudio added a commit that referenced this issue May 26, 2019
…fact

In GH-133 (1) and GH-134 (2) two new configuration files were added,
but not added to the ignore pattern file for the `vsce` tool that
packages the distributed `.vsix` artifact.

References:
  (1) #133
  (2) #134

Fixes GH-136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant