Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduction-related changes to getNetQuantificationProjection #418

Merged
merged 9 commits into from
Apr 1, 2024

Conversation

amiecorso
Copy link
Contributor

@amiecorso amiecorso commented Mar 23, 2024

Updates the getNetQuantificationProjection algorithm to make use of deducted unadjusted totals if they are present, instead of the undeducted numbers.

Part of ticket NO-3610

Copy link

swarmia bot commented Mar 23, 2024

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.8%. Comparing base (7548d77) to head (1305023).

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #418   +/-   ##
======================================
  Coverage    95.7%   95.8%           
======================================
  Files          35      35           
  Lines        1119    1124    +5     
  Branches      254     255    +1     
======================================
+ Hits         1072    1077    +5     
  Misses         44      44           
  Partials        3       3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amiecorso amiecorso marked this pull request as ready for review March 27, 2024 21:50
@amiecorso amiecorso requested a review from rlfarman March 27, 2024 21:50
@amiecorso amiecorso merged commit 885e309 into master Apr 1, 2024
7 checks passed
@amiecorso amiecorso deleted the amie-deductions-netquantification-changes branch April 1, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants