Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boost::timer with std::chrono::steady_clock #598

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

boxanm
Copy link
Collaborator

@boxanm boxanm commented Jan 12, 2025

Description

Summary:

This PR addresses #597 and the deprecation of boost::timer when not using POSIX timers.
It also adds a CMake variable DISABLE_POSIX_TIMERS to control whether the POSIX timers or std::chrono::steady_clock are used. Finally there is a simple example script showing how to use PointMatcherSupport::timer in code.

Checklist:

Code related

  • I have made corresponding changes to the documentation
    (i.e.: function, class, script header, README.md)
  • I have commented hard-to-understand code
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
    (Check contributing_instructions.md for local testing procedure using libpointmatcher-build-system)

PR creation related

  • My pull request base ref branch is set to the develop branch
    (the build-system won't be triggered otherwise)
  • My pull request branch is up-to-date with the develop branch
    (the build-system will reject it otherwise)

PR description related

  • I have included a quick summary of the changes
  • I have indicated the related issue's id with # <issue-id> if changes are of type fix
  • I have included a high-level list of changes and their corresponding types
    (See commit_msg_reference.md for details)

pointmatcher/Timer.cpp Outdated Show resolved Hide resolved
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants